[OpenWrt-Devel] [PATCH v2 05/16] file: fix error string about "unterminated XXX".

Yousong Zhou yszhou4tech at gmail.com
Tue Dec 16 02:00:07 EST 2014


 - Remove unreachable call to uci_parse_error().
 - Fix false claim of unterminated double quote to single quote.

Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
---
 file.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/file.c b/file.c
index 3f02c11..0fc68a6 100644
--- a/file.c
+++ b/file.c
@@ -157,7 +157,6 @@ static void parse_double_quote(struct uci_context *ctx, int *target)
 			break;
 		}
 	}
-	uci_parse_error(ctx, "unterminated \"");
 }
 
 /*
@@ -180,14 +179,13 @@ static void parse_single_quote(struct uci_context *ctx, int *target)
 			/* Multi-line str value */
 			uci_getln(ctx, pctx->pos);
 			if (!pctx_cur_char(pctx))
-				uci_parse_error(ctx, "EOF with unterminated \"");
+				uci_parse_error(ctx, "EOF with unterminated '");
 
 			break;
 		default:
 			addc(ctx, target, &pctx->pos);
 		}
 	}
-	uci_parse_error(ctx, "unterminated '");
 }
 
 /*
-- 
1.7.10.4
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list