[OpenWrt-Devel] [PATCH 1/3] brcm63xx: add bcm6345-gpio driver

Florian Fainelli florian at openwrt.org
Mon Dec 15 10:15:42 EST 2014


2014-12-12 6:33 GMT-08:00 Jonas Gorski <jogo at openwrt.org>:
> On Fri, Dec 12, 2014 at 3:17 PM, John Crispin <blogic at openwrt.org> wrote:
>>
>>
>> On 12/12/2014 15:12, Jonas Gorski wrote:
>>> or the gpio-base problem, we should be able to register appropriate
>>> platform data for it as OF_DEV_AUXDATA() in of_platform_populate.
>>>
>>> e.g.
>>>
>>> struct bgpio_pdata gpio0_pdata  = {
>>>       .base = 0,
>>> };
>>>
>>> struct bgpio_pdata gpio1_pdata  = {
>>>       .base = 32,
>>> };
>>
>> tried it for ralink and lantiq and it got nak'ed by LinusW
>>
>> i keep that part of the code as a small patch inside owrt on top of the
>> stuff i sent upstream.
>
> Wasn't the objection on putting the gpio base into the dts(i) file
> itself? I explicitly try to avoid that here, as gpio-base is something
> linux internal.

Right that is typically the objection, but with the new gpio
descriptor based API, we should not have that problem anymore, right?

>
> But It doesn't matter much for now as not even basic DT support is
> upstream, so these won't go anywhere soon.

--
Florian
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list