[OpenWrt-Devel] [PATCH][RESEND] [tools] toolchain: ensure tools are built and staged before preparing toolchain

[Felix Fietkau]

On 2014-12-13 10:43, John Szakmeister wrote:
> On Sat, Dec 13, 2014 at 4:28 AM, John Szakmeister <john at szakmeister.net> wrote:
> [snip]
>>> This doesn't look right to me, I don't think we should add the
>>> toolchain/prepare step as an intermediate target for the regular build
>>> process.
>>> How about just adding this line to Makefile and leaving out the rest:
>>>
>>> toolchain/prepare: $(tools/stamp-install)
>>
>> Who will depend on the toolchain/prepare to make sure that it
>> happens before toolchain/install?  I couldn't find this
>> happening automatically in the Makefiles, that's why I went
>> through the work of setting up the intermediate target.
>>
>> Trying your version locally fails.
> 
> Turns out this second version doesn't work either.  One of my
> branches had the first version of the fix in it.  FWIW, the
> first thing I tried was the following, but it didn't seem like
> the right approach--though it does work correctly:
How do you reproduce the failure on your system? I've been building with
-j8 and higher for a long time now without seeing anything from
toolchain/ being built before tools/

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel