[OpenWrt-Devel] [PATCH 3/3][RFC] ag71xx_ar7240 add new switch func export_netdevs

[John Crispin]

On 10/12/2014 08:21, Florian Fainelli wrote:
> Le 9 déc. 2014 11:22, "Alexander Couzens" <lynxis at fe80.eu 
> <mailto:lynxis at fe80.eu>> a écrit :
>> 
>> export_netdevs will export a net device for every port. These
>> netdev
> represent a port
>> with out traffic. When such a device is broght down via ifconfig
>> the port is shutdown and vice versa. Carrier sense is working too
>> and ethtool can be used to control advertise, autoneg, ...
> 
> And you just duplicated DSA, which now supports not using a
> particular tagging protocol, just network devices for the ethtool
> control path. Can you take a look at using DSA and coming up with
> an ar7240 driver if this is the direction we want to take here?

if at all we want to use DSA. to me the patch looks like an ugly hack
that implements stuff in the driver that should be generic.

i agree with florian that this is a NAK

	John

> 
> 



> 
> _______________________________________________ openwrt-devel
> mailing list openwrt-devel at lists.openwrt.org 
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
> 
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel