[OpenWrt-Devel] [PATCH RFC] broadcom-wl: use CCMP by default for WPA (version 1)

[Felix Fietkau]

On 2014-12-04 11:28, Rafał Miłecki wrote:
> On 18 November 2014 at 12:19, Rafał Miłecki <zajec5 at gmail.com> wrote:
>> I can see multiple files:
>> /sbin/wifi
>> /lib/wifi/mac80211.sh
>> /lib/netifd/wireless/mac80211.sh
>> /lib/netifd/hostapd.sh
>> but they mostly don't contain any comments.
>>
>> I'm not sure how much it's worth to list unclear parts of that.
>>
>> It's confusing to have /lib/netifd/ and /lib/wifi/. It's confusing to
>> have two APIs (inconsistent callbacks). I can't understand why even
>> for mac80211.sh we keep detecting code in /lib/wifi/. There isn't
>> anything documented in the /lib/netifd/netifd-wireless.sh. I have no
>> idea how netifd <-> scripts communication works. What is handled in
>> scripts and what in netifd?
> 
> You say that /lib/wifi/*sh is legacy layer. I can understand we need
> it for Broadcom or similar. But what's the point of having mac80211
> there?
> 
> Also why do we have something like /lib/netifd/hostapd.sh? Isn't
> wireless stuff supposed to be in /lib/netifd/wireless/?
/lib/netifd/wireless/*.sh contains handler scripts executed by netifd
directly. /lib/netifd/hostapd.sh is just an include used by
/lib/netifd/wireless/mac80211.sh.
The only reason that /lib/wifi/mac80211.sh is still there is that netifd
doesn't handle detecting devices and generating default configurations
for them. I have removed the actual device setup logic from it a long
time ago.
John is currently reworking device detection (including for wifi) - once
that's done, /lib/wifi/mac80211.sh can be removed.

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel