[OpenWrt-Devel] [PATCH][ar71xx] Add support for BHU Networks BXO2000n-2S/BXO5000n-2S/BXI2000n-2/BXO2000n-2S-U

[John Crispin]

Hi,

patches for new boards are always welcome, a few comments below

On 04/12/2014 08:23, yangbo wrote:
> +/*
> + * BHU BXO2000n-2S-U board
> + */
> +
> +static void __init bhu_bxo2000n2s_u_setup(void)
> +{
> +	bhu_ap123_setup((u8 *) KSEG1ADDR(0x1fff0000), (u8 *) KSEG1ADDR(0x1fff1000));
> +
> +    ath79_register_leds_gpio(-1, ARRAY_SIZE(bhu_bxo2000n2s_leds_gpio),
> +                 bhu_bxo2000n2s_leds_gpio);

     ^ the patch is full of leading space vs tab errors like this.
please fix them and resend the patch. i am not sure how the other mach
files handle it but i would prefer to have all the #defines at the start
of the file rather than have it intermingled with the code.

	John


> +
> +    ath79_register_gpio_keys_polled(1, BHU_BXO2000N2S_KEYS_POLL_INTERVAL,
> +                    ARRAY_SIZE(bhu_bxo2000n2s_gpio_keys),
> +                    bhu_bxo2000n2s_gpio_keys);
> +}
> +
> +MIPS_MACHINE(ATH79_MACH_BHU_BXO2000N2SU, "BXO2000n-2S-U",
> +         "BHU BXO2000n-2S-U",
> +         bhu_bxo2000n2s_u_setup);
> +
> +/*
> + * BHU BXI2000n-2 board
> + */
> +
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel