[OpenWrt-Devel] [PATCH] ar71xx: make LED names for EnGenius routers follow convention

[Forest Crossman]

[Resending because I forgot to reply-all]

That’s what I thought originally, but I asked Jon Suphammer why he used the model name instead of the manufacturer in his patch for the EnGenius ESR1750, he responded: 

> Hi Forest, 
> 
> Vendors are not always consistent over time with what colour they use 
> for their LED's. Several factors could play in, like matching LED with 
> a tooling colour or just change of mind. 
> It would be more safe to bind the LED to specific device rather than vendor. 
> 
> Best regards, 
> Jon 

I agree with him in that it would be better to identify LEDs by model instead of by brand since there is a more direct relationship between the LED and that model than the LED and the manufacturer. 

In the end, what the LED is called doesn’t really matter since it’s just an arbitrary string. At some point, though, I think we should document one convention to be used across all platforms and models. Or, even better, get rid of the brand/manufacturer identifier entirely and make it something simpler like "wlan2g:blue", "power:amber", "wps:green", "wps:red", etc. 

-- 
Forest Crossman

On August 20, 2014 at 9:24:28 PM, Yousong Zhou (yszhou4tech at gmail.com(mailto:yszhou4tech at gmail.com)) wrote:

> That’s what I thought originally, but I asked Jon Suphammer why he used the model name instead of the manufacturer in his patch for the EnGenius ESR1750, he responded:  
>  
> > Hi Forest,  
> >  
> > Vendors are not always consistent over time with what colour they use  
> > for their LED's. Several factors could play in, like matching LED with  
> > a tooling colour or just change of mind.  
> > It would be more safe to bind the LED to specific device rather than vendor.  
> >  
> > Best regards,  
> > Jon  
>  
> I agree with him in that it would be better to identify LEDs by model instead of by brand since there is a more direct relationship between the LED and that model than the LED and the manufacturer.  
>  
> In the end, what the LED is called doesn’t really matter since it’s just an arbitrary string. At some point, though, I think we should document one convention to be used across all platforms and models. Or, even better, get rid of the brand/manufacturer identifier entirely and make it something simpler like “wlan2g:blue”, “power:amber”, “wps:green”, “wps:red”, etc.  
>  
> --  
> Forest Crossman
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel