[FS#4150] ./script/feeds does not return error on failure

OpenWrt Bugs openwrt-bugs at lists.openwrt.org
Sat Nov 27 04:19:07 PST 2021


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#4150 - ./script/feeds does not return error on failure
User who did this - Hannu Nyman (hnyman)

----------
> Script feeds always returns 0

Not quite true. 
The return value logic depends on the command used. For example, the "update" command was patched by me in 2015 to provide an error on failed feed updates.

Based on the source code, also the package install step usually provides an error code, with the exception of the case that you encountered: no feed found. Then there is plain "return 0" despite the error condition.

https://github.com/openwrt/openwrt/blob/master/scripts/feeds#L597-L613

(The same situation seems to be with the subfunction install_src:  https://github.com/openwrt/openwrt/blob/master/scripts/feeds#L523-L524 )
----------

More information can be found at the following URL:
https://bugs.openwrt.org/index.php?do=details&task_id=4150#comment10346

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.



More information about the openwrt-bugs mailing list