[FS#3655] autoconf-lean causes variating breakage at buildbot and private buildhosts

[OpenWrt Bugs]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Hannu Nyman (hnyman) 

Attached to Project - OpenWrt/LEDE Project
Summary - autoconf-lean causes variating breakage at buildbot and private buildhosts
Task Type - Bug Report
Category - Base system
Status - Unconfirmed
Assigned To - 
Operating System - All
Severity - Low
Priority - Very Low
Reported Version - Trunk
Due in Version - Undecided
Due Date - Undecided
Details - autoconf-lean stuff from Felix was merged by Daniel a few days ago to master with commits
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=32c664ff02910bf39a3fbd5a5a4a8bff3191dd03  and
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=f439e291304a93b982e912dc91b80ca950a594f3

That seems to cause buildhost-specific variation in the generated site config files, and causes variating breakage from some packages.

I stumbled upon this on weekend with ntfs-3g, which suddenly does not compile in my Ubuntu 20.10 in Virtualbox. I filed a bug about ntfs-3g to packages feed, but this is more generic:
https://github.com/openwrt/packages/issues/14940


The same buildhost builds 21.02 without problems (and that is still pretty identical to master regarding packages)

Reverting autoconf-lean commits fixes things for me.

There are now others with the same symptoms, based on responses to the packages feed bug.

Buildbot is now meeting the same problem. At least ntfs-3g, rsync, nedata, and possibly also mac80211 and mwlwifi are failing for some targets with some buildhosts (with the new SDK).

E.g.
https://downloads.openwrt.org/snapshots/faillogs/aarch64_cortex-a72/packages/ntfs-3g/compile.txt



OpenWrt-libtool: compile:  aarch64-openwrt-linux-musl-gcc -DHAVE_CONFIG_H -I. -I.. -I../include/fuse-lite -I/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a72_gcc-8.4.0_musl/usr/include -I/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a72_gcc-8.4.0_musl/include/fortify -I/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a72_gcc-8.4.0_musl/include -I../include/ntfs-3g -Os -pipe -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable -Wno-error=unused-result -ffile-prefix-map=/builder/shared-workdir/build/sdk/build_dir/target-aarch64_cortex-a72_musl/ntfs-3g-2017.3.23-4-fuseint=ntfs-3g-2017.3.23-4-fuseint -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -Wall -MT libntfs_3g_la-ioctl.lo -MD -MP -MF .deps/libntfs_3g_la-ioctl.Tpo -c ioctl.c  -fPIC -DPIC -o .libs/libntfs_3g_la-ioctl.o
ioctl.c: In function 'fstrim_limits':
ioctl.c:164:3: warning: implicit declaration of function 'major' [-Wimplicit-function-declaration]
   major(statbuf.st_rdev), minor(statbuf.st_rdev));
   ^~~~~
ioctl.c:164:27: warning: implicit declaration of function 'minor'; did you mean 'mknod'? [-Wimplicit-function-declaration]
   major(statbuf.st_rdev), minor(statbuf.st_rdev));
                           ^~~~~
                           mknod
...
.libs/ntfsfix ntfsfix.o utils.o  -L/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a72_gcc-8.4.0_musl/usr/lib -L/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a72_gcc-8.4.0_musl/lib ../libntfs-3g/.libs/libntfs-3g.so -lc
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a72_gcc-8.4.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/8.4.0/../../../../aarch64-openwrt-linux-musl/bin/ld: ../libntfs-3g/.libs/libntfs-3g.so: undefined reference to `minor'
/builder/shared-workdir/build/sdk/staging_dir/toolchain-aarch64_cortex-a72_gcc-8.4.0_musl/bin/../lib/gcc/aarch64-openwrt-linux-musl/8.4.0/../../../../aarch64-openwrt-linux-musl/bin/ld: ../libntfs-3g/.libs/libntfs-3g.so: undefined reference to `major'
collect2: error: ld returned 1 exit status
Makefile:939: recipe for target 'ntfsfix' failed
make[6]: *** [ntfsfix] Error 1
make[6]: Leaving directory '/builder/shared-workdir/build/sdk/build_dir/target-aarch64_cortex-a72_musl/ntfs-3g-2017.3.23-4-fuseint/ntfsprogs'
Makefile:504: recipe for target 'all-recursive' failed
make[5]: *** [all-recursive] Error 1


https://downloads.openwrt.org/snapshots/faillogs/aarch64_cortex-a72/packages/rsync/compile.txt

flist.c: In function 'send_file_entry':
flist.c:438:16: warning: implicit declaration of function 'major' [-Wimplicit-function-declaration]
    if ((uint32)major(rdev) == rdev_major)
                ^~~~~
flist.c:442:41: warning: implicit declaration of function 'minor'; did you mean 'mknod'? [-Wimplicit-function-declaration]
    if (protocol_version < 30 && (uint32)minor(rdev)