[LEDE-DEV] merge: add OpenWrt branding

Zoltan HERPAI wigyori at uid0.hu
Tue Oct 24 10:49:36 EDT 2017


Hi Hannu,

On Tue, 24 Oct 2017, Hannu Nyman wrote:

> Zoltan HERPAI kirjoitti 24.10.2017 klo 14:46:
>> Given that we've decided to sail under the same flag for
>> the benefit of the whole community, and acknowledge the
>> achievements of the LEDE project, let's start the final
>> steps of the merge.
>>      The git and other sources are untouched until the infra merge.
>>      ...
>
>> @@ -1,10 +1,13 @@
>> -   \  DE    \  /    %N (%V, %C)
>> + DESIGNATED DRIVER (%C, %R)
> Please do not re-introduce hard-coded version branding into various files.
>
> All version info was centralised to include/version.mk by this commit:
>
> https://github.com/lede-project/source/commit/3193053df7d27bde82fbcc310e4404cc43f39313#diff-d08225593c57fc07ce549597f7fd4c68
>
> and further refined with
>
> https://github.com/lede-project/source/commit/5f3c96c28503b8a0aad1514ef144b15e670d338b#diff-d08225593c57fc07ce549597f7fd4c68

Yep, this was pointed out by Jo as well, will change it.


> Ps.
>
> And are the drinks really back on the menu?

I think at least a vote was about to happen on this topic for the next 
release :)

-w-




More information about the openwrt-adm mailing list