[OpenWrt-Tickets] [OpenWrt] #3122: AR7 DSL has error in /proc files

[OpenWrt]

#3122: AR7 DSL has error in /proc files
----------------------+-----------------------------------------------------
 Reporter:  matteo    |        Owner:  matteo
     Type:  defect    |       Status:  new   
 Priority:  normal    |    Milestone:        
Component:  packages  |   Resolution:        
 Keywords:            |  
----------------------+-----------------------------------------------------
Comment (by nabcore):

 The struture for ctl_table may have changed recently and the adsl driver
 is out of sync with it. The struture is as follows:


 {{{
 struct ctl_table
 {
         int ctl_name;                   /* Binary ID */
         const char *procname;           /* Text ID for /proc/sys, or zero
 */
         void *data;
         int maxlen;
         mode_t mode;
         struct ctl_table *child;
         struct ctl_table *parent;       /* Automatically set */
         proc_handler *proc_handler;     /* Callback for text formatting */
         ctl_handler *strategy;          /* Callback function for all r/w
 */
         void *extra1;
         void *extra2;
 };
 }}}


 I think the issue lies in tn7dsl.c :


 {{{
 ctl_table dslmod_table[] = {
   {DEV_DSLMOD, "dslmod", info, DSL_MOD_SIZE, 0644, NULL, &dslmod_sysctl}
   ,
   {0}
   };
 }}}

 Changing this to :


 {{{
 ctl_table dslmod_table[] = {
   {DEV_DSLMOD, "dslmod", info, DSL_MOD_SIZE, 0644, NULL, NULL, NULL,
 &dslmod_sysctl}
   ,
   {0}
   };
 }}}

 solves the first error (Missing strategy), but I'm not sure how to solve
 the other two errors. It may also be related to this:

 {{{
 /* Make sure that /proc/sys/dev is there */
 ctl_table dslmod_root_table[] = {
 #ifdef CONFIG_PROC_FS
   {CTL_DEV, "dev", NULL, 0, 0555, dslmod_table}
   ,
 #endif /* CONFIG_PROC_FS */
   {0}
   };

 }}}

-- 
Ticket URL: <https://dev.openwrt.org/ticket/3122#comment:1>
OpenWrt <http://openwrt.org>
Opensource Wireless Router Technology