qoriq: Watchguard Firebox M300 source only

[Evan Jobling]

Thanks for the response Stijn.

> It would help if you link the forum post. People tend to have their preferred communication media. Forums definitely don't fit that category for me, so the chance of me missing things there are extremely high.
I only recently joined the forum myself.
Email FTW haha.

https://forum.openwrt.org/t/get-qoriq-target-enabled-in-snapshot/142548/5
Only other thing I found was another post on someone asking how to get it
installed in February.
>>
>> I'm wondering whether anyone can provide input on what work would be required
>> to get this from source-only into the snapshot builds etc?
> The target was made source-only because it is considered exotic, and most likely had only a handful of users initially. If that has changed, I'm perfectly fine with removing source-only on qoriq in its current state.
Mm. I guess most people don't need cheap 8 port router in rack mount with a low power dissipation.
Given competitors in the market now I don't know the best solution either.

I'm of the opinion that the number of users is suppressed due keeping it source only.
i.e. This target is always going to remain exotic if there aren't readily available images compiled for it.
Availability is less now anyway so users may always be low?

My goals now are just getting the device naming modifications up streamed so I can use it
without maintaining out of tree patches.

>> Correct interface naming.
I have a working set of modifications correcting the interface names.
> IIRC, the M300 has 2 ports connected to the switch. We should figure out how to make that work, rather than removing the currently unused CPU port.
Yeah this is going to require further investigation.
Bonding or splitting the masters would be nice in terms of speed to CPU.
I can see only limited application so I'm probably not going to 
spend more effort in the near term.

> IIRC, you simply cannot rename ethernet interfaces with device tree.
Mm. I found that openwrt already did renaming in preinit.
I sent through a set of modifications for comment that renamed the devices
in preinit.

Further to that direction,I was hoping to find a way to refer to
DSA user network interfaces by a known path.
i.e. like you can with the interfaces that have .ethernet paths.
At the moment a second naming pass was the best I could come
up with.

>>
>>
>> Packages:
>> I noticed that lots of packages required CONFIG_BROKEN=y set.
> Could you give some examples? I have not enabled CONFIG_BROKEN=y anywhere, and I have been running 2 M300's in a HA setup for several years. Might be unrelated to QorIQ.
Thanks for calling me on this.
Can't replicate the issue.
My feeds must have been broken when I was first trying to build this target.

> I don't really use LuCI, so can't be of help here. But this should also not block us from removing source-only from qoriq.
I'll need to investigate further. Haven't done LuCI development before.
Thanks for confirming that's not a blocker.

This appears to be an issue with network interfaces not
coming up unless they're in LAN or WAN networks.
i.e. when using ucidef_set_interface  in board.d
They weren't coming up under luci-mod-status.

But I should be able to replicate that in a VM if that's the actual cause.

>>
>> Cheers,
>> Evan.
> 
> I propose you send a patch to remove source-only from the qoriq target in its current form. If there are no objections within 2 weeks after submission I'll merge it and poke people to reconfigure the buildbots.
> 
> We can look into everything else on an individual basis.
I hope that promoting this device will lead to more users and testers for this target.
But you also mentioned above that you only wanted to do this change if there are more users?

I'll send through a patch after the mac address pull request goes through.
Probably coupled with my set of changes to base files/preinit to get the
Ethernet device naming correct.

Cheers,
Evan.