snort3 (at least) not building in 23.05

[Jonas Gorski]

Hi Eric,

On Tue, 9 Apr 2024 at 18:59, Eric via openwrt-devel
<openwrt-devel at lists.openwrt.org> wrote:
>
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
>
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.
>
>
> ---------- Forwarded message ----------
> From: Eric <evil.function at proton.me>
> To: openwrt-devel <openwrt-devel at lists.openwrt.org>
> Cc:
> Bcc:
> Date: Tue, 09 Apr 2024 16:59:01 +0000
> Subject: snort3 (at least) not building in 23.05
> I noticed this before, but never looked at it.  snort3 is building packages for all releases and snapshot since it was introduced, but it is not building in 23.05.
> https://forum.openwrt.org/t/snort-on-openwrt-23-05-3/194225
>
> If I run
> $ scripts/feeds clean
> $ make clean
> $ git checkout main (or v23.05.3)
> $ scripts/feeds update -a
> $ scripts/feeds install -1
>
> then
> $ find . -iname '*snort3*'
>
> everything looks fine, both main and 23.05 branch show the expected package
>
> $ ll package/feeds/packages/snort3/
> Permissions Size User      Date Modified    Git Name
> drwxr-xr-x@    - efahlgren 2024-04-09 09:27  -- .
> drwxr-xr-x@    - efahlgren 2024-04-09 09:27  -- ..
> drwxr-xr-x@    - efahlgren 2024-04-09 09:27  -- files
> .rw-r--r--@ 4.3k efahlgren 2024-04-09 09:27  -- Makefile
>
> I do
> $ make menuconfig
> and then search '/snort3', both v23.05.3 and main show expected path at 'Network -> Firewall', but in 23.05 when I navigate to that tree, snort3 does not appear at the expected location.
>
> So, I manually modify .config, adding 'CONFIG_PACKAGE_snort3=m', then run 'make defconfig', it disappears from .config
>
> $ grep snort .config
> CONFIG_PACKAGE_snort3=m
>
> $ make defconfig
> WARNING: Makefile 'package/feeds/packages/libmpc/Makefile' has a dependency on 'libmpfr', which does not exist
> WARNING: Makefile 'package/feeds/packages/python-gmpy2/Makefile' has a dependency on 'libmpfr', which does not exist
> #
> # configuration written to .config
> #
>
> $ grep snort .config
> # CONFIG_PACKAGE_snort is not set
>
> And then, of course, building results in no snort3...
>
> Anyone have a clue what could do this?

A quick look at the package history points at
https://github.com/openwrt/packages/commit/cd5f6637f2c500aa24ed453f510d5e5821c25496
which added a dependency on HAS_LUAJIT_ARCH, but the commit adding the
symbol https://github.com/openwrt/packages/commit/5eea661fdb797462412530a07e73c27e57eb8677
was never backported to 23.05. So snort3 in 23.05 depends on a
non-existing symbol, causing it to be unselectable/buildable.

Can you open an issue for that at https://github.com/openwrt/packages/issues ?

Best Regards,
Jonas