[PATCH 6/7] lldpd: make management address advertisement controllable

[Jo-Philipp Wich]

Hi,

comment below.

Am 4/2/24 um 15:02 schrieb Paul Donald:
> Defaults to off.
> 
> Available from >= 0.7.15
> 
> These are sent in TLV
> 
> Signed-off-by: Paul Donald <newtwen+github at gmail.com>
> ---
>   package/network/services/lldpd/files/lldpd.init | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init
> index 3e804cd033..72baf19cc5 100644
> --- a/package/network/services/lldpd/files/lldpd.init
> +++ b/package/network/services/lldpd/files/lldpd.init
> @@ -128,6 +128,10 @@ write_lldpd_conf()
>   	local lldp_capadv
>   	config_get_bool lldp_capadv 'config' 'lldp_capadv' 0
>   
> +	# Broadcast management address in lldpd >= 0.7.15
> +	local lldp_maddradv
> +	config_get_bool lldp_maddradv 'config' 'lldp_maddradv' 0

Same remark as for the previous patch, please spell out those option names. 
Nobody will be able to guess what a "maddradv" is. It is not a widely used 
acronym and it is not similar to the native 
"management-addresses-advertisements" setting name.

Also there's an existing option "lldp_mgmt_ip" and I guess this new option 
controls whether it is advertised in TLVs or not, so it should follow its 
naming, something like "lldp_mgmt_ip_advertisement" or similar.

~ Jo