[PATCH] bcm53xx: Unconditionally build U-Boot for DIR-890L

Arınç ÜNAL arinc.unal at arinc9.com
Tue Sep 5 01:27:20 PDT 2023

On 4.09.2023 23:58, Linus Walleij wrote:
> On Mon, Sep 4, 2023 at 12:03 PM Rafał Miłecki <rafal at milecki.pl> wrote:
>> I don't see anything incorrect with Linus's original patch. Maybe we
>> just have some dependency handling issue in u-boot generic .mk code?
> I have transient problem with the dependencies at times, then
> I just chose another target (entirely different!) in menuconfig and
> then back to the intended target. Problem fixed, dependency
> selected. It feels a bit shaky though, but usually all autobuilds
> work fine.

Perhaps I wasn't clear enough to explain the issue. As Rafał has already
said, there's nothing wrong with enabling the package when DIR-890L is
selected as the device.

The problem is when another device is selected. OpenWrt SDK shouldn't
compile an image for the devices that are not selected on menuconfig. Yet
it does anyway.

This is the first time on the bcm53xx target that compiling the image for a
device requires a package to be built first. This has exposed an underlying
issue. When a device that is not DIR-890L is selected, the u-boot package
won't be enabled. An image for DIR-890L will be attempted to be compiled
which will fail because the u-boot package is not enabled.

To make it clear, what needs fixing is making OpenWrt SDK not compile an
image for the devices that are not selected on menuconfig.

I don't know GNU Make very well to figure out why this happens on the
bcm53xx target. I don't see this happening on the mt7621 subtarget of the
ramips target.


More information about the openwrt-devel mailing list