[PATCH master,23.05] ramips: fix ZyXEL NR7101 bricking typo

Christian Marangi ansuelsmth at gmail.com
Sun Oct 15 12:35:08 PDT 2023

On Sun, Oct 15, 2023 at 09:59:57PM +0200, Paul D wrote:
> On 2023-10-15 19:41, Bjørn Mork wrote:
> > A typo snuck in with the addition of Cudy M1800, changing
> > "nr7101" to "nt7101". The result is a default network config
> > for NR7101 without the only ethernet interface on the NR7101,
> > thereby soft bricking it.
> > 
> > Fixes: f6d394e9f2fd ("ramips: add support for Cudy M1800")
> > Signed-off-by: Bjørn Mork <bjorn at mork.no>
> > ---
> > Ref https://forum.openwrt.org/t/zyxel-nr7101-not-responding-after-flashing-initramfs/174409
> > and https://github.com/openwrt/openwrt/pull/13699
> > 
> > This needs to be applied to 23.05 and master ASAP.  It is already
> > bricking devices.
> > 
> > And it would be great if we could have some automated check
> > to help us spot these kinds of unrelated and unexpected
> > changes.  I don't think the regular review process will ever
> > be able to catch this, as that is mostly focues on the newly
> > added device.
> While I second the urgency of this, I venture the question of how one might
> otherwise catch these things, but for sharp eyes. There is an attention
> deficit with respect to the volume of patches and PRs that come in.

Well the only solution is being more aggressive with nitpicking and
request very dry patch with less patch delta as possible.

The PR was introducing a new device so it's understandable to not think
that on moving code, the guy introduced a typo in rewiting the entry in
the shell...

It's both trusting the submitter and not expecting these kind of error


More information about the openwrt-devel mailing list