[PATCH] mac80211: always use mac80211 loss detection

David Bauer mail at david-bauer.net
Thu May 18 02:19:12 PDT 2023


ath10k does not report excessive loss in case of broken block-ack
sessions. The loss is communicated to the host-os, but ath10k does not
trigger a low-ack events by itself.

The mac80211 framework for loss detection however detects this
circumstance well in case of ath10k. So use it regardless of ath10k's
own loss detection mechanism.

Signed-off-by: David Bauer <mail at david-bauer.net>
---
 ...1-always-use-mac80211-loss-detection.patch | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/kernel/mac80211/patches/subsys/340-mac80211-always-use-mac80211-loss-detection.patch

diff --git a/package/kernel/mac80211/patches/subsys/340-mac80211-always-use-mac80211-loss-detection.patch b/package/kernel/mac80211/patches/subsys/340-mac80211-always-use-mac80211-loss-detection.patch
new file mode 100644
index 0000000000..1e3a41c302
--- /dev/null
+++ b/package/kernel/mac80211/patches/subsys/340-mac80211-always-use-mac80211-loss-detection.patch
@@ -0,0 +1,33 @@
+From cdf461888f900c3a149b10a04d72b4a590ecdec3 Mon Sep 17 00:00:00 2001
+From: David Bauer <mail at david-bauer.net>
+Date: Tue, 16 May 2023 23:11:32 +0200
+Subject: [PATCH] mac80211: always use mac80211 loss detection
+
+ath10k does not report excessive loss in case of broken block-ack
+sessions. The loss is communicated to the host-os, but ath10k does not
+trigger a low-ack events by itself.
+
+The mac80211 framework for loss detection however detects this
+circumstance well in case of ath10k. So use it regardless of ath10k's
+own loss detection mechanism.
+
+Signed-off-by: David Bauer <mail at david-bauer.net>
+---
+ net/mac80211/status.c | 6 ------
+ 1 file changed, 6 deletions(-)
+
+--- a/net/mac80211/status.c
++++ b/net/mac80211/status.c
+@@ -794,12 +794,6 @@ static void ieee80211_lost_packet(struct
+ 	unsigned long pkt_time = STA_LOST_PKT_TIME;
+ 	unsigned int pkt_thr = STA_LOST_PKT_THRESHOLD;
+ 
+-	/* If driver relies on its own algorithm for station kickout, skip
+-	 * mac80211 packet loss mechanism.
+-	 */
+-	if (ieee80211_hw_check(&sta->local->hw, REPORTS_LOW_ACK))
+-		return;
+-
+ 	/* This packet was aggregated but doesn't carry status info */
+ 	if ((info->flags & IEEE80211_TX_CTL_AMPDU) &&
+ 	    !(info->flags & IEEE80211_TX_STAT_AMPDU))
-- 
2.39.2




More information about the openwrt-devel mailing list