bug in ddns-scripts

e9hack e9hack at gmail.com
Fri Mar 10 07:47:40 PST 2023


Hi,

it looks like there is a bug in ddns-scripts. In dynamic_dns_updater.sh:

   70 case "$1" in
   71         start)
   72                 if [ -n "$NETWORK" ]; then
   73                         start_daemon_for_all_ddns_sections "$NETWORK"
   74                         exit 0
   75                 fi
   76                 if [ -z "$SECTION_ID" ]; then
   77                         start_daemon_for_all_ddns_sections
   78                         exit 0
   79                 fi
   80                 ;;
   81         stop)
   82                 if [ -n "$INTERFACE" ]; then
   83                         stop_daemon_for_all_ddns_sections "$NETWORK"
   84                         exit 0
   85                 else
   86                         stop_daemon_for_all_ddns_sections
   87                         exit 0
   88                 fi
   89                 exit 1
   90                 ;;
   91         reload)
   92                 killall -1 dynamic_dns_updater.sh 2>/dev/null
   93                 exit $?
   94                 ;;
   95         *)      usage_err "unknown command - $1";;
   96 esac

Shouldn't be the test in 'stop' for '-n $NETWORK' instead for '-n $INTERFACE'?

Regards,
Hartmut



More information about the openwrt-devel mailing list