[PATCH v2] mvebu: add support for Fortinet FortiGate 50E

[INAGAKI Hiroshi]

Hi Hauke,

thank you for your review.

On 2023/03/06 1:42, Hauke Mehrtens wrote:
> On 3/1/23 17:01, INAGAKI Hiroshi wrote:
>> Fortinet FortiGate 50E (FG-50E) is a UTM, based on Armada 385 (88F6820).
> ....
>>
>> Notes:
>>
>> - All "SPEED" LEDs(Green/Amber) of LAN and 1000M "SPEED" LEDs(Green) of
>>    WAN1/2 are connected to GPIO expander. There is no way to indicate
>>    link speed of networking device, so those LEDs cannot be used like
>>    stock firmware.
>
> I think you can use the ledtrig-netdev to activate the LEDs on link up 
> if they are connected to the nxp,pca9555 GPIO extender.

I didn't think about it since "LINK/ACT" LEDs already indicate link up, 
but it certainly might be a good alternative for "SPEED" LEDs.

>
>> - Both colors of Bi-color LEDs on the front panel cannot be turned on at
>>    the same time.
>>
>> - "PWR" and "Logo" LEDs are connected to power source directory.
>>
>> - The following partitions are added for OpenWrt.
>>    These partitions are contained in "uboot" partition (0x0-0x1fffff) on
>>    stock firmware.
>>
>>    - "firmware-info"
>>    - "dtb"
>>    - "u-boot-env"
>>    - "board-info"
>>
> .....
>>   +define Device/fortinet_fg-50e
>> +  DEVICE_VENDOR := Fortinet
>> +  DEVICE_MODEL := FortiGate 50E
>> +  SOC := armada-385
>> +  KERNEL := kernel-bin | append-dtb
>> +  KERNEL_INITRAMFS := kernel-bin | append-dtb | fortigate-header | \
>> +    gzip-filename FGT50E
>> +  KERNEL_SIZE := 6144k
>> +  DEVICE_DTS := armada-385-fortinet-fg-50e
>> +  IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | \
>> +    sysupgrade-tar rootfs=$$$$@ | append-metadata
>> +  DEVICE_PACKAGES := kmod-hwmon-nct7802
>
> Why don't you add the driver for the GPIO extender kmod-gpio-pca953x 
> here?

CONFIG_GPIO_PCA953X (and irq option) is enabled in mvebu/config-5.15[1], 
so I didn't add that package.

[1]: 
https://github.com/openwrt/openwrt/blob/a03076cc392b67c8342aac2017f8ac903c983e59/target/linux/mvebu/config-5.15#L191-L192

>
>> +endef
>> +TARGET_DEVICES += fortinet_fg-50e
>> +
>>   define Device/globalscale_mirabox
>>     $(Device/NAND-512K)
>>     DEVICE_VENDOR := Globalscale
>

Regards,
Hiroshi