[netifd PATCH] bridge: always insert new member if allocated on hotplug add

Felix Fietkau nbd at nbd.name
Sat Jun 24 11:54:59 PDT 2023

On 24.06.23 14:34, Christian Marangi wrote:
> Fix Coverity Defect 1532481 reporting a Resource leak when
> !bm->node.avl.key is false in bridge_hotplug_add.
> While this situation is almost impossible, code can be refactored to
> mute the defect and make it clear that we insert only when a new member
> is allocated.
> Fixes: edf3aced9f9a ("bridge: add support for adding vlan ranges via hotplug")
> Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>
Applied with some changes to make it clear that this is a false positive 


- Felix

More information about the openwrt-devel mailing list