[PATCH-22.03 01/10] ipq40xx: Support Chromium OS image-type creation

[Petr Štetiar]

openwrt at aiyionpri.me <openwrt at aiyionpri.me> [2023-04-07 15:23:39]:

Hi Jan,

> This series intends to support Google WiFi device 'Gale'.

IMHO it screams "a lot of regressions" in exchange for adding support for a
_single_ device into sixth stable release of 22.03, and considering that we've
23.05 already in the works, I'm sorry, but I'm going to reject this
contribution.

> I think I found all relevant commits and testing looked promising.

Looking at the ipq-wifi fallout, it looks like you've made some backports into
22.03 already?

> diff --git a/package/base-files/files/lib/upgrade/common.sh b/package/base-files/files/lib/upgrade/common.sh
> index 24ff77a8b3..5af061f6a4 100644
> --- a/package/base-files/files/lib/upgrade/common.sh
> +++ b/package/base-files/files/lib/upgrade/common.sh
> @@ -155,9 +155,11 @@ export_bootdevice() {
>  				fi
>  			done
>  		;;
> +		PARTUUID=????????-????-????-????-??????????0?/PARTNROFF=1 | \
>  		PARTUUID=????????-????-????-????-??????????02)
>  			uuid="${rootpart#PARTUUID=}"
> -			uuid="${uuid%02}00"
> +			uuid="${uuid%/PARTNROFF=1}"
> +			uuid="${uuid%0?}00"
>  			for disk in $(find /dev -type b); do
>  				set -- $(dd if=$disk bs=1 skip=568 count=16 2>/dev/null | hexdump -v -e '8/1 "%02x "" "2/1 "%02x""-"6/1 "%02x"')
>  				if [ "$4$3$2$1-$6$5-$8$7-$9" = "$uuid" ]; then

sysupgrade path, very high regression potential, not a bugfix, so not going to consider merging it.

> diff --git a/package/firmware/ipq-wifi/Makefile b/package/firmware/ipq-wifi/Makefile
> index be9b547cd0..74d789bdf6 100644
> --- a/package/firmware/ipq-wifi/Makefile
> +++ b/package/firmware/ipq-wifi/Makefile
> @@ -43,6 +43,7 @@ ALLWIFIBOARDS:= \
>  	glinet_gl-ap1300 \
>  	glinet_gl-b2200 \
>  	glinet_gl-s1300 \
> +	google_wifi \
>  	linksys_ea8300 \
>  	linksys_mr8300-v0 \
>  	luma_wrtq-329acn \

This doesn't apply, looks like you're not even using 22.03 as a base for this
contribution?

> This effectively reverts upstream Linux commit 13e77747800e ("firmware:
> qcom: scm: Use atomic SCM for cold boot"), because Google WiFi boot
> firmwares don't support the atomic variant.
> 
> This fixes SMP support for Google WiFi.

This is actually a fix, but needed just for the device being added, but still
might bring in some regression potential. 

Cheers,

Petr