[iwinfo PATCH v2] devices: add support for declaring compatible matched devices

Andre Heider a.heider at gmail.com
Mon Jan 9 12:58:19 PST 2023

On 09/01/2023 21:44, Andre Heider wrote:
> On 09/01/2023 20:49, Christian Marangi wrote:
>> From: Jo-Philipp Wich <jo at mein.io>
>> Some device have embedded wifi card that are not connected with usb or
>> internall with pci. Such device have fake device_id and only the
>> vendor_id actually reflect something real but internally they don't have
>> any id and are just matched by the node compatible binding in DT.
>> We currently match this with a big if-else to match the single devices
>> but this can be improved and be matched directly in devices.txt
>> Rework this so that we can drop the big if-else and move the matching
>> to devices.txt
>> When a device is matched using compatible in iwinfo the hardware will be
>> flagged as embedded and won't print empty ids.
>> Update devices.txt by migrating all the compatible matching device from
>> fake id to compatible matching.
>> Tested-by: Christian Marangi <ansuelsmth at gmail.com> # ipq4019
>> Co-developed-by: Christian Marangi <ansuelsmth at gmail.com>
>> Signed-off-by: Jo-Philipp Wich <jo at mein.io>
>> Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>
>> Tested-by: Robert Marko <robimarko at gmail.com> # ipq8074
> Reviewed-by: Andre Heider <a.heider at gmail.com>

Forgot to mention, but stating the obvious:
This changes the ABI (adding new members to public structs), so a 
recompilation of all users is sufficient to avoid problems. Hence, 
please bump IWINFO_ABI_VERSION once this is merged and the package gets 

While on that topic, the few remaining patches from PR#11280 are in the 
same boat. Can we get those merged too, pretty please?


More information about the openwrt-devel mailing list