[PATCH] iwinfo: devices: add Qualcomm Atheros QCN6024/9024/9074 cards

Daniel Golle daniel at makrotopia.org
Fri Jan 6 08:44:27 PST 2023


On Fri, Jan 06, 2023 at 05:32:48PM +0100, Robert Marko wrote:
> On Fri, 6 Jan 2023 at 17:31, Christian Marangi <ansuelsmth at gmail.com> wrote:
> >
> > On Fri, Jan 06, 2023 at 05:14:37PM +0100, Robert Marko wrote:
> > > Add Qualcomm Atheros QCN6024/9024/9074 PCI ID, they all are compatible and
> > > use the same ID.
> > >
> > > Signed-off-by: Robert Marko <robimarko at gmail.com>
> >
> > Hi,
> > can you send a v2 with the iwinfo from the title dropped?
> >
> > Something like [iwinfo PATCH] devices: ...
> >
> > Just notice the different naming convention.
> 
> Sure, but its a bit weird to send iwinfo patches to OpenWrt mailing
> list without a prefix
> of subproject?

better to have that subproject name it in brackets, as in that way it
doesn't end up as a prefix in the git commit (where it is useless --
all commits in iwinfo repo are related to iwinfo, obviously...) and
yet allows us to use `git am` to merge it without having to edit.

> 
> Regards,
> Robert
> >
> > > ---
> > >  devices.txt | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/devices.txt b/devices.txt
> > > index bc0257c..d76bbca 100644
> > > --- a/devices.txt
> > > +++ b/devices.txt
> > > @@ -173,6 +173,7 @@
> > >  0x168c 0x0046 0x168c 0xcafe    0      0  "Qualcomm Atheros" "QCA9984"
> > >  0x168c 0x0050 0x0000 0x0000    0      0  "Qualcomm Atheros" "QCA9887"
> > >  0x168c 0x0056 0x0000 0x0000    0      0  "Qualcomm Atheros" "QCA9886"
> > > +0x17cb 0x1104 0x17cb 0x1104    0      0  "Qualcomm Atheros" "QCN6024/9024/9074"
> > >  0x1814 0x3050 0x1814 0x0005    0      0  "Ralink"   "Rt3050"
> > >  0x1814 0x3051 0x1814 0x0007    0      0  "Ralink"   "Rt3051"
> > >  0x1814 0x3052 0x1814 0x0008    0      0  "Ralink"   "Rt3052"
> > > --
> > > 2.39.0
> > >
> > >
> > > _______________________________________________
> > > openwrt-devel mailing list
> > > openwrt-devel at lists.openwrt.org
> > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> >
> > --
> >         Ansuel
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list