[PATCH RESEND 02/11] kernel/generic: remove CONFIG_FB_NOTIFY

Elliott Mitchell ehem+openwrt at m5p.com
Tue Dec 12 17:12:37 PST 2023


On Tue, Dec 12, 2023 at 04:48:32PM +0100, Jonas Gorski wrote:
> 
> On Sun, 10 Dec 2023 at 18:49, Elliott Mitchell <ehem+openwrt at m5p.com> wrote:
> >
> > Date: Tue, 25 Apr 2023 16:23:20 -0700
> >
> > This option is automatically enabled by CONFIG_FB=y.  There is no
> > reason to specifically enable it.
> 
> Unfortunately this change will cause the symbol to appear in target
> configs when using make kernel_*config. Ideally a make kernel_*config
> without any changes should result in no changed files (currently it
> does so for many targets).

I strongly dislike this approach.  Problem is forces the configuration
files to contain both values which were deliberately chosen and values
which are simply defaults (and defaults can change due to drivers
becoming mature).  Perhaps my other project could invalidate the
reasoning behind this choice.  Hmm.

> To avoid that, I guess adding the symbol to
> target/linux/generic/config-filter should do the trick so it becomes
> properly ignored for config management.

I'm okay with that.  Presently have this is in my repository.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg at m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445





More information about the openwrt-devel mailing list