help to submit patch

John Thomson lists at johnthomson.fastmail.com.au
Thu Sep 22 18:38:00 PDT 2022


Hi,

On Thu, 22 Sep 2022, at 19:49, davidea wrote:
> hi guys, i get some LTE module HUAWEI model EC200AEUHA-N06-SNASA , this 
> module arent' recognized from the kernel, or better, the kernel 
> recognize the CDC-ETHER section, but not the ttyUSB were i must 
> configure the APN and lunch the connection
>
> root at OpenWrt:~# lsusb
> Bus 002 Device 001: ID 1d6b:0001 Linux 5.4.203 ohci_hcd Generic Platform 
> OHCI controller
> Bus 001 Device 002: ID 2c7c:6005 Android Android
> Bus 001 Device 001: ID 1d6b:0002 Linux 5.4.203 ehci_hcd EHCI Host 
> Controller
> root at OpenWrt:~#
>
> it's the 2c7c:6005 usbid
>
> then i check for huawei support and they pointed me in the right 
> direction (they give me the source code for some x64 processor)
>
> i check it, and some other pdf and i try to patch openwrt
>
> i downloaded the openwrt code, and tried to modify the option.c file under
>
> openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt76x8/linux-5.4.203/drivers/usb/serial/option.c
>
> adding the definition for this pid
>
>
> #define QUECTEL_PRODUCT_RM500K                  0x7001
> +#define QUECTEL_PRODUCT_EC200A                  0x6005
> #define CMOTECH_VENDOR_ID                       0x16d8
>
>
>          { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> QUECTEL_PRODUCT_EC200S_CN, 0xff, 0, 0) },
> +        { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> QUECTEL_PRODUCT_EC200A, 0xff, 0, 0) },
>          { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, 
> QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },
>
>
> i complie the code and it's work, now i've the ttyUSB0 to 2 device
>
> how can i submit this patch??
>

You will need to use git to format and submit your change.

Ideally, you submit this change "upstream", to the Linux mailing lists.
The documentation about this process here:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Here are examples of making this addition for a similar device:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/usb/serial/option.c
An email which was sent to get a change to happen:
https://lore.kernel.org/all/MEYP282MB23740DC78FB0DE954C59D3DEFD8F9@MEYP282MB2374.AUSP282.PROD.OUTLOOK.COM/
For these USB changes, the commit message includes the relevant parts from /sys/kernel/debug/usb/devices, or usb-devices shell script. Some of them also have lsusb -v for the device:
https://lore.kernel.org/linux-usb/20210809133553.71158-1-zhangzhengjun@aicrobo.com/

You then wait for this change to be included in a linux-stable release,
or add a kernel patch to OpenWrt (see target/linux/generic/pending-5.10 in the OpenWrt tree for examples) as well:
https://openwrt.org/docs/guide-developer/toolchain/use-patches-with-buildsystem#adding_or_editing_kernel_patches
https://openwrt.org/submitting-patches


You might get better responses to these process-related queries on the OpenWrt Forum.


Cheers,
-- 
  John



More information about the openwrt-devel mailing list