[PATCH] realtek: fix RTL839x receive tag decoding

Luiz Angelo Daros de Luca luizluca at gmail.com
Thu Sep 15 12:57:28 PDT 2022

> > The previous fixup was incomplete, and the offsets for the
> > queue and crc_error cpu_tag bitfields were still wrong on
> > RTL839x.
> >
> > Fixes: 545c6113c93b ("realtek: fix RTL838x receive tag decoding")
> > Suggested-by: Jan Hoffmann <jan at 3e8.eu>
> > Signed-off-by: Bjørn Mork <bjorn at mork.no>
> > ---
> > Jan pointed put that I missed two fields on the RTL839x. Sloppy. Fix
> > those as well.
> >
> > This time even without complaints from checkpatch :-)
> >
> > But build tested only.  I don't have any 839x and I don't know how
> > to verify these features anyway.
> +CC Andreas, Hiroshi, Luiz, Markus as rtl839x users.

I was hoping this would fix the missing vlan tag for traffic that goes
through the switch.
I just tested https://github.com/openwrt/openwrt/pull/10643 rebased on
current master
and the issue is the same: tagged vlan to tagged vlan forwarded by the
switch is sent untagged while tagged traffic that goes
to/from the CPU works as expected. It does not seem to be related to
the received tag. It looks like the tag
is added correctly by the CPU but the switch is not configured
correctly to add a tag for traffic to a specific vlan.
I would bet it is the internal switch vlan setup, not the linux side.

BTW, it might be time to merge that PR as, AFAIK, this vlan issue
affects the SoC, not that specific device.



More information about the openwrt-devel mailing list