[PATCH v2 1/2] ramips: fix GB-PC1 and GB-PC2 LEDs
Arınç ÜNAL
arinc.unal at arinc9.com
Wed Sep 14 11:30:59 PDT 2022
Add the missing LEDs for GB-PC2. Some of these LEDs don't exist on the
device schematics. Tests on a GB-PC2 by me and Petr proved otherwise.
Remove ethblack-green and ethblue-green LEDs for GB-PC1. They are not wired
to GPIO 3 or 4 and the wiring is currently unknown.
Set ethyellow-orange to display link state and activity of the ethyellow
interface for GB-PC2.
Link: https://github.com/ngiger/GnuBee_Docs/blob/master/GB-PCx/Documents/GB-PC2_V1.1_schematic.pdf
Tested-by: Petr Louda <petr.louda at outlook.cz>
Signed-off-by: Arınç ÜNAL <arinc.unal at arinc9.com>
---
v2: Correct misinformation in the patch log.
---
.../linux/ramips/dts/mt7621_gnubee_gb-pc1.dts | 10 ----------
.../linux/ramips/dts/mt7621_gnubee_gb-pc2.dts | 18 ++++++++++++++----
.../mt7621/base-files/etc/board.d/01_leds | 4 +---
3 files changed, 15 insertions(+), 17 deletions(-)
diff --git a/target/linux/ramips/dts/mt7621_gnubee_gb-pc1.dts b/target/linux/ramips/dts/mt7621_gnubee_gb-pc1.dts
index 29f9f09ee5..809df6dde3 100644
--- a/target/linux/ramips/dts/mt7621_gnubee_gb-pc1.dts
+++ b/target/linux/ramips/dts/mt7621_gnubee_gb-pc1.dts
@@ -27,16 +27,6 @@
leds {
compatible = "gpio-leds";
- ethblack_act {
- label = "green:ethblack_act";
- gpios = <&gpio 3 GPIO_ACTIVE_LOW>;
- };
-
- ethblue_act {
- label = "green:ethblue_act";
- gpios = <&gpio 4 GPIO_ACTIVE_LOW>;
- };
-
power {
label = "green:power";
gpios = <&gpio 6 GPIO_ACTIVE_LOW>;
diff --git a/target/linux/ramips/dts/mt7621_gnubee_gb-pc2.dts b/target/linux/ramips/dts/mt7621_gnubee_gb-pc2.dts
index cd72ea1d62..6199511cff 100644
--- a/target/linux/ramips/dts/mt7621_gnubee_gb-pc2.dts
+++ b/target/linux/ramips/dts/mt7621_gnubee_gb-pc2.dts
@@ -27,16 +27,26 @@
leds {
compatible = "gpio-leds";
- ethblack_act {
- label = "green:ethblack_act";
+ ethblack-green {
+ label = "green:ethblack";
gpios = <&gpio 3 GPIO_ACTIVE_LOW>;
};
- ethblue_act {
- label = "green:ethblue_act";
+ ethblue-green {
+ label = "green:ethblue";
gpios = <&gpio 4 GPIO_ACTIVE_LOW>;
};
+ ethyellow-green {
+ label = "green:ethyellow";
+ gpios = <&gpio 15 GPIO_ACTIVE_LOW>;
+ };
+
+ ethyellow-orange {
+ label = "orange:ethyellow";
+ gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
+ };
+
power {
label = "green:power";
gpios = <&gpio 6 GPIO_ACTIVE_LOW>;
diff --git a/target/linux/ramips/mt7621/base-files/etc/board.d/01_leds b/target/linux/ramips/mt7621/base-files/etc/board.d/01_leds
index 0ac67e9670..5ffa4ecb3a 100644
--- a/target/linux/ramips/mt7621/base-files/etc/board.d/01_leds
+++ b/target/linux/ramips/mt7621/base-files/etc/board.d/01_leds
@@ -67,10 +67,8 @@ dlink,dir-882-a1|\
dlink,dir-882-r1)
ucidef_set_led_netdev "wan" "wan" "green:net" "wan"
;;
-gnubee,gb-pc1|\
gnubee,gb-pc2)
- ucidef_set_led_netdev "ethblack_act" "ethblack act" "green:ethblack_act" "ethblack" "tx rx"
- ucidef_set_led_netdev "ethblue_act" "ethblue act" "green:ethblue_act" "ethblue" "tx rx"
+ ucidef_set_led_netdev "ethyellow" "ethyellow" "orange:ethyellow" "ethyellow" "link tx rx"
;;
linksys,e5600)
ucidef_set_led_netdev "wan" "wan link" "blue:wan" "wan" "link"
--
2.34.1
More information about the openwrt-devel
mailing list