[PATCH 0/5] realtek: avoid blocking for too long
Sander Vanheule
sander at svanheule.net
Sun Oct 23 13:24:32 PDT 2022
On Fri, 2022-10-14 at 23:06 +0200, Jan Hoffmann wrote:
> This fixes multiple instances where the realtek drivers may block for
> too long. These issues were discovered on HPE 1920 devices where such
> behaviour is made obvious by the short timeout of the hardware watchdog.
>
> This patch series intentionally doesn't address calls to pr_debug which
> may also block for long enough to cause issues. Those calls are only
> effective if the kernel is built with support for debug messages, which
> is a non-default configuration. Also, it is really an issue with printk
> itself and in no way specific to the realtek drivers. It is already
> being worked on upstream by moving to threaded printk.
>
> Jan Hoffmann (5):
> realtek: avoid busy waiting for RTL839x PHY read/write
> realtek: simplify log messages in rtl83xx_mdio_probe
> realtek: add debugfs node for L2 table
> realtek: reduce excessive logging for FDB operations
> realtek: restructure rtl_table_read/write
These patches look good to me, but I agree with Andreas's remark for "realtek:
simplify log messages in rtl83xx_mdio_probe". If you don't get any comments on
moving cond_resched() to the loops, can you do a respin?
I've already picked patches 1, 3, and 4. So you would only need to do the two
remaining ones.
Best,
Sander
More information about the openwrt-devel
mailing list