[PATCH v1 1/2] realtek: remove RTL839x path in RTL838x multicast

Sander Vanheule sander at svanheule.net
Thu Oct 6 14:13:27 PDT 2022


On Mon, 2022-09-12 at 22:06 +0200, Sander Vanheule wrote:
> The multicast setup function rtl838x_eth_set_multicast_list() checks if
> the current SoC is a RTL839x family device. However, the function is
> only included in the RTL838x ops table, so this path should never be
> taken, making this dead code. rtl839x_eth_set_multicast_list() is
> already present in the RTL839x ops table, so it should be safe to remove
> this branch.
> 
> While touching the code, also re-sort the functions to match sorting
> elsewhere, with rtl838x coming before rtl839x.
> 
> Signed-off-by: Sander Vanheule <sander at svanheule.net>
> ---

Would anybody still like to comment on this patch or the RMA flooding patch? If
you would like to test them, you can also consult some well-known address tables
[1, 2] to check if it affects any of your applications.

If not, I'll probably just merge them after the weekend.

[1] https://en.wikipedia.org/wiki/Multicast_address#Ethernet
[2]
http://www.thaemlitz.com/john/ieee-company_id-mac-address-table.html?mac=01-80-C2-00-00


Best,
Sander




More information about the openwrt-devel mailing list