[PATCH] treewide: remove label = "cpu" from DSA dt-binding

Arınç ÜNAL arinc.unal at arinc9.com
Wed Nov 30 09:52:06 PST 2022


On 30.11.2022 19:50, Jonas Gorski wrote:
> On Wed, 30 Nov 2022 at 15:43, Arınç ÜNAL <arinc.unal at arinc9.com> wrote:
>>
>> This is not used by the DSA dt-binding, so remove it from all devicetrees.
>>
>> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9cc115d8d6f73dd260de1609182f3645844d6907
>> Signed-off-by: Arınç ÜNAL <arinc.unal at arinc9.com>
>>
>> ---
>>
>> These devicetrees do not define the ethernet property for CPU ports.
>> target/linux/bcm63xx/dts/bcm63169-comtrend-vg-8050.dts
>> target/linux/bcm63xx/dts/bcm6362-huawei-hg253s-v2.dts
>> target/linux/bcm63xx/dts/bcm6368-netgear-dgnd3700-v1.dts
>> target/linux/bcm63xx/dts/bcm6369-comtrend-wap-5813n.dts
>> target/linux/mpc85xx/files/arch/powerpc/boot/dts/panda.dts
>>
>> There might be OpenWrt maintained code somewhere that checks for label cpu
>> on these. If anyone has got one of these devices, please test network
>> connectivity with this patch applied.
> 
> The swconfig b53 driver uses the label to identify the cpu port, so
> NAK for bcm63xx, and I guess panda / mpc85xx/p1020.
> 
> https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/generic/files/drivers/net/phy/b53/b53_common.c;h=87d731ec3e2a868dc8389f554b1dc9ab42c30be2;hb=HEAD#l1508

Thanks for pointing this out. Bindings on bcm63xx and panda DTs are not 
DSA dt-bindings so I'll drop them.

Arınç



More information about the openwrt-devel mailing list