[PATCH] procd: jail/jail: correctly check for null pointer

[Daniel Golle]

On Tue, Nov 08, 2022 at 02:26:47PM +0000, Philipp Meier via openwrt-devel wrote:
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
> 
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.

> Date: Tue, 8 Nov 2022 14:26:47 +0000
> From: Philipp Meier <Philipp.Meier at westermo.com>
> To: John Crispin <john at phrozen.org>
> CC: "openwrt-devel at lists.openwrt.org" <openwrt-devel at lists.openwrt.org>
> Subject: [PATCH] procd: jail/jail: correctly check for null pointer
> 
> Author: Philipp Meier <philipp.meier at westermo.com>
> Date:   Tue Nov 8 14:38:37 2022 +0100

This looks like the output of `git show`.
Please use `git format-patch` or `git send-email` in future.

> 
>     procd: jail/jail: correctly check for null pointer
>     
>     Handle case where opts.sysctl is not used.
>     
>     Signed-off-by: Philipp Meier <philipp.meier at westermo.com>

I've cleaned and picked up your patch, thank you!

> 
> diff --git a/jail/jail.c b/jail/jail.c
> index ce6b268..31b64e5 100644
> --- a/jail/jail.c
> +++ b/jail/jail.c
> @@ -215,6 +215,10 @@ static void free_hooklist(struct hook_execvpe **hooklist)
>  
>  static void free_sysctl(void) {
>         struct sysctl_val *cur;
> +
> +       if (!opts.sysctl)
> +               return;
> +

The patch somehow got white-space mangled (tabs got converted to spaces),
probably by copy & pasting it into some MUA. If you really have no way to
use `git send-email` and also importing a draft email created using
`git format-patch` cannot work for you, please attach the file created
by `git format-patch`. Using copy & paste will *always* create a lot of
extra work, because one then has to apply the patch manually (which is also
error-prone and should be avoided).

>         cur = *opts.sysctl;
>  
>         while (cur) {
> 

> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel