[PATCH] usteer: Fix better candidate not being set in policy

David Bauer mail at david-bauer.net
Tue May 17 07:22:33 PDT 2022


Hi,

On 5/17/22 14:12, Wojciech Dubowik wrote:
> The candidate is never set in this loop. Fix it by setting it
> to the first valid entry.

Applied to master. Thanks!

Best
David

> 
> Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik at westermo.com>
> ---
>   policy.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/policy.c b/policy.c
> index a7efc06..8155e24 100644
> --- a/policy.c
> +++ b/policy.c
> @@ -143,7 +143,7 @@ find_better_candidate(struct sta_info *si_ref, struct uevent *ev, uint32_t requi
>   			ev->select_reasons = reasons;
>   		}
>   
> -		if (candidate && si->signal > candidate->signal)
> +		if (!candidate || si->signal > candidate->signal)
>   			candidate = si;
>   	}
>   



More information about the openwrt-devel mailing list