[PATCH] realtek: Fix kernel dependencies on CONFIG_MDIO_SMBUS

Bjørn Mork bjorn at mork.no
Tue Mar 15 07:10:04 PDT 2022

Bjørn Mork <bjorn at mork.no> writes:

> Just drop the unnecssary I2C_SMBUS dependency.  AFAICS, you're only
> using i2c_smbus_xfer() which is part of the i2c core.

Looking further at this, I believe there are good reasons to simply
merge the mdio-smbus implementation into mdio-i2c: You seem to have lost
some clause 45 specific stuff from commit 6912b712cd75 ("net: mdio-i2c:
add support for Clause 45 accesses")

And the i2c_mii_valid_phy_id() tests to avoid eeprom access are also
missing.  Maybe not important, but demonstrating the problems with
copying code.  Even modules as small as these tend to grow apart over

I guess the clause 45 support could be important for multigig copper


More information about the openwrt-devel mailing list