[PATCH] realtek: correct egress frame port verification

Birger Koblitz mail at birger-koblitz.de
Sun Jun 19 02:40:05 PDT 2022


Hi,

On 19.06.22 10:56, Sander Vanheule wrote:

> -	h->cpu_tag[1] = h->cpu_tag[2] = 0;
> -	if (prio >= 0)
> -		h->cpu_tag[2] = BIT(13) | prio << 8; // Enable and set Priority Queue
> +	h->cpu_tag[1] = 0;
> +	/* Enable (AS_QID) and set Priority Queue (QID) */
> +	h->cpu_tag[2] = (BIT(5) | (prio & 0x1f)) << 8;
You are removing the possibility to let the SoC choose a Queue on its own based on congestion,
if you always enable AS_QID. There was a reason that there were negative Queue-ID values, which
denoted allowing the SoC to choose, i.e. AS_QID was not set.

Cheers,
  Birger




More information about the openwrt-devel mailing list