[PATCH v1 5/5] realtek: remove hardcoded sys-led configurations

Birger Koblitz mail at birger-koblitz.de
Tue Jun 7 02:29:01 PDT 2022


Hi,

On 07.06.22 11:10, Sander Vanheule wrote:
> On Tue, 2022-06-07 at 10:24 +0200, Birger Koblitz wrote:
>> Hi,
>>
>> at least for the RTL931x, removing the rtl931x_setup() is not a good idea as the WDT reset does
>> not work for that architecture.
>> The only way to get a working reset is via registering a reset handler:
>>
>> static void __init rtl931x_setup(void)
>> {
>>         pr_info("Registering _machine_restart\n");
>>         _machine_restart = rtl931x_restart;
>>         _machine_halt = rtl931x_halt;
> 
> We've gotten rid of _machine_restart and _machine_halt already, let's not reintroduce them.
> 
> If you don't feel like writing a driver for the reset controller, perhaps syscon-reboot [1] can be
> useful?
That sounds interesting, I'll try.

Cheers,
  Birger



More information about the openwrt-devel mailing list