[PATCH] packages: pagekitec: fix crashing due to musl time64

Lukas Zeller luz at plan44.ch
Sat Jun 4 10:49:02 PDT 2022

> On 3 Jun 2022, at 23:10, Karl Palsson <karlp at tweak.net.au> wrote:
> [...] Ideally, even make the patch against upstream:
> https://github.com/pagekite/libpagekite so they are involved and
> can help with it going forward, especially for cases like this,
> where it's not anything that's OpenWrt related.

Thanks for the hint. Yes, this makes more sense, so I just posted a PR

I modified the fix a bit as Rosen Penev is correct to criticise the
use of %lld together with an uint64_t cast. It would replace one mismatch
with another, just less critical one...

However, I chose to keep %lld and cast to long long instead, as we
generally don't know what time_t really is. As long
as there is no PRItime_t, this seems more generic to me than uint64_t.

> I'll try and poke upstream about this personally too.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20220604/1d71397c/attachment.sig>

More information about the openwrt-devel mailing list