[PATCH] ramips: add support for Notion R281 (mtd5)

[Arınç ÜNAL]

On 24.07.2022 15:34, Ian Pangilinan wrote:
>> On 2022-07-24 19:53, Arınç ÜNAL wrote:
>> On 24.07.2022 14:48, Ian Pangilinan wrote:
>>>> On 2022-07-24 18:32, Arınç ÜNAL wrote:
>>>> On 24.07.2022 12:38, Ian Pangilinan wrote:
>>>>> +	keys {
>>>>> +		compatible = "gpio-keys";
>>>>> +
>>>>> +		/* use wps as wifi button */
>>>>> +		key-wifi {
>>>>> +			label = "wifi";
>>>>> +			gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
>>>>> +			linux,code = <KEY_RFKILL>;
>>>>> +		};
>>>>> +
>>>>> +		key-reset {
>>>>> +			label = "reset";
>>>>> +			gpios = <&gpio 7 GPIO_ACTIVE_LOW>;
>>>>> +			linux,code = <KEY_RESTART>;
>>>>> +		};
>>>>> +	};
>>>>> +};
>>>>> +
>>>>> +&state_default {
>>>>> +	gpio {
>>>>> +		groups = "jtag", "rgmii2", "uart3";
>>>>> +		function = "gpio";
>>>>> +	};
>>>>> +};
>>>>
>>>> Please remove this node. It is unnecessary and claiming the rgmii2
>>>> group here will break gmac1 configuration.
>>>
>>> I have removed rgmii2 from the group. But I could not remove the
>>> state_default node, as I have not fully applied the patch series yet
>>> to my locally cloned OpenWrt git repo, which will involve changes to
>>> mt7621.dtsi and a hundred other device-tree files, which will render
>>> this patch unable to be applied to master as your pull request is
>>> still pending.
>>
>> You can either revert your gmac1 configuration (because that requires
>> my PR as well) or remove this node and put a disclaimer to require my
>> PR to be applied for this patch to be applied.
>>
> 
> This is my first time to submit a patch on this mailing list, so forgive
> me for being a little hard on the head. ;) But, I don't see why I can't
> use the relevant part of your patch series, which is not dependent on
> the
> other changes made, to make the change as intended by your PR.

Of course you can. This is exactly what I want this patch to become. 
However, don't take half measures while you do that. Removing this node 
will not render the patch in a state where it is unable to be applied if 
my PR was not applied beforehand, which I wrongfully said otherwise 
above. So, take the full measure and remove this node, along with the 
other changes you have already made.

Arınç