[PATCH] kernel/crypto: fix crypto-lib-curve25519 x86_64 build

Florian Eckert fe at dev.tdt.de
Fri Jul 22 00:28:42 PDT 2022


On 2022-07-21 17:10, Stijn Tintel wrote:
> On 21/07/2022 15:17, Florian Eckert wrote:
>> The crypto-lib-curve25519 dependency for x86_64 could not be met,
>> because the package for for the architecture x86_64 was not added to
>> crypto-lib-curve package. Also the package arch definition for x86/64
>> does not exist. It musst be change to x86_64 to get added.
> 
> Can you please elaborate why this is needed? My x86/64 image contains
> curve25519_x86_64.ko without this change.

Hello Stijn

I am currently working on a target for integration in Openwrt (Lightning 
Mountain).
This is a x86_64 architecture with 4 Atoms CPUs. I have added a new 
target (mxl) and
subtarget (lgm) with $(ARCH) x86_64.

But If I do it like this, then the module could not be build because,
the dependency is not met. "Missing

So far it only works now if I set the $(BOARD) value to x86 in the 
Makefile and
I also have to add a $(SUBTARGET) 64 in my directory mxl which in my 
case does not fit.

I also wanted to make it equal to the packages kmod-crypto-lib-poly1305.
This package maps this via $(ARCH) and doesn't do any special handling.

So I would prefer if we make it dependent on the $(ARCH) variable.
Also in the linux kernel this is also  under /arch/x86.

I think we should also update [1]
https://github.com/TDT-AG/openwrt/blob/master/package/kernel/linux/modules/crypto.mk#L464


Best regards

Florian

[1] 
https://github.com/TDT-AG/openwrt/blob/master/package/kernel/linux/modules/crypto.mk#L545

> 
> Thanks,
> Stijn
> 
> [1]
> https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=include/kernel.mk;h=001718d89d8b77bf7843c5cba77ef519f808e085;hb=HEAD#l213



More information about the openwrt-devel mailing list