Proposed reviewers to include in patches
ryazanov.s.a at gmail.com
Tue Jan 18 14:20:27 PST 2022
On Mon, Jan 17, 2022 at 5:11 PM Mauri Sandberg <maukka at ext.kapsi.fi> wrote:
> I sent a patch set for review two months back but I am yet to receive
> any comments, ack/nack. Maybe nobody took action since I did not Cc:
> anyone specifically.
> Are there ppl who normally carry out reviews or should I just resend the
> patch set?
Generally, this is a good idea to include people who are involved in a
particular component development to the CC list. You could check the
committer field of git log --pretty=full to grab a list of involved
And even with filled CC, a patch can be overlooked. A month ago I
tried to raise a discussion on IRC about a good practice on how to
draw some attention to submitted patches. After that discussion I
started thinking that most devs are Ok if a submitter "pings" them
once a week. So just reply to your initial submission with a "gentle
ping" to bump your patch in the list.
More information about the openwrt-devel