[PATCH v2 2/2] ramips: support TP-Link EAP615-Wall

[Sander Vanheule]

On Sat, 2022-02-26 at 12:11 +0200, Stijn Tintel wrote:
> Add support for the TP-Link EAP615-Wall, an AX1800 Wall Plate WiFi 6 AP.
> The device is very similar to the TP-Link EAP235-Wall.
> 
> Hardware:
> * SoC: MediaTek MT7621AT
> * RAM: 128MiB
> * Flash: 16MiB SPI-NOR
> * Ethernet: 4x GbE
>   * Back: ETH0 (PoE-PD)
>   * Bottom: ETH1, ETH2, ETH3 (PoE passthrough)
> * WiFi: MT7905DAN/MT7975DN 2.4/5 GHz 2T2R
> * LEDS: 1x white
> * Buttons: 1x LED, 1x reset
> 
> Stock firmware uses a random MAC address for ethernet. OpenWrt uses the
> MAC address that is on the device label for ethernet and the wireless
> interfaces. MAC address must not be incremented, as this will cause MAC
> address conflicts in case you have two devices with consecutive MAC
> addresses. Instead, different locally administered addresses will be
> generated automatically, based on the MAC on the label.
> 
> Installation via stock firmware:
> * Enable SSH in the TP-Link web interface
> * SSH to the device
> * Run `cliclientd stopcs`
> * Upload the OpenWrt factory image via the TP-Link web interface
> 
> Installation via bootloader:
> * Solder TTL header. Pinout: 1: TX, 2: RX, 3: GND, 4: VCC, with pin 1
>   closest to ETH1. Baud rate 115200
> * Interrupt boot process by holding a key during boot
> * Boot the OpenWrt initramfs:
>   # tftpboot 0x84000000 openwrt-ramips-mt7621-tplink_eap615-wall-v1-initramfs-kernel.bin
>   # bootm
> * Copy openwrt-ramips-mt7621-tplink_eap615-wall-v1-squashfs-sysupgrade.bin
>   to /tmp and use sysupgrade to install it
> 
> Thanks to Sander Vanheule for his work on the EAP235-Wall, which made
> adding support for the EAP615-Wall very easy.
> 
> Signed-off-by: Stijn Tintel <stijn at linux-ipv6.be>

With the minor comments below addressed:
Reviewed-by: Sander Vanheule <sander at svanheule.net>


> ---
> v2: - PoE-PT -> PoE passthrough
>     - MT7915E -> MT7905DAN/MT7975DN
>     - dropped ethernet at 1e100000, moved reg override to &ethernet
>     - dropped bus-range from &pcie
>     - dropped port at 5 from &switch0
>     - added dsa-migration
>     - kept kernel padding as it silences a warning
>     - firmware-tools change committed to firmware-tools.git 
> ---
>  .../dts/mt7621_tplink_eap615-wall-v1.dts      | 210 ++++++++++++++++++
>  target/linux/ramips/image/mt7621.mk           |  13 ++
>  .../mt7621/base-files/etc/board.d/02_network  |   3 +-
>  3 files changed, 225 insertions(+), 1 deletion(-)
>  create mode 100644 target/linux/ramips/dts/mt7621_tplink_eap615-wall-v1.dts
> 
> diff --git a/target/linux/ramips/dts/mt7621_tplink_eap615-wall-v1.dts
> b/target/linux/ramips/dts/mt7621_tplink_eap615-wall-v1.dts
> new file mode 100644
> index 0000000000..a57fe9cc97
> --- /dev/null
> +++ b/target/linux/ramips/dts/mt7621_tplink_eap615-wall-v1.dts
> @@ -0,0 +1,210 @@

...

> +
> +&spi0 {
> +       status = "okay";
> +
> +       flash at 0 {
> +               compatible = "jedec,spi-nor";
> +               reg = <0>;
> +               spi-max-frequency = <20000000>;
> +
> +               partitions {
> +                       compatible = "fixed-partitions";
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +
> +                       partition at 0 {
> +                               label = "u-boot";
> +                               reg = <0x0 0x80000>;
> +                               read-only;
> +                       };
> +
> +                       partition at 80000 {
> +                               label = "partition-table";
> +                               reg = <0x80000 0x10000>;
> +                               read-only;
> +                       };
> +
> +                       info: partition at 90000 {
> +                               label = "product-info";
> +                               reg = <0x90000 0x10000>;
> +                               read-only;
> +                       };
> +
> +                       partition at a0000 {
> +                               compatible = "denx,fit";
> +                               label = "firmware";
> +                               reg = <0x0a0000 0xcf0000>;
> +                       };

Leading zero in "0x0a0000", but other offsets don't have them.

> +
> +                       partition at d90000 {
> +                               label = "user-config";
> +                               reg = <0xd90000 0x60000>;
> +                               read-only;
> +                       };
> +
> +                       partition at f30000 {
> +                               label = "mutil-log";
> +                               reg = <0xf30000 0x80000>;
> +                               read-only;
> +                       };
> +
> +                       partition at fb0000 {
> +                               label = "oops";
> +                               reg = <0xfb0000 0x040000>;

"0x040000" > "0x40000", or use six digits (with leading zero) for all sizes.

> +                               read-only;
> +                       };
> +
> +                       radio: partition at ff0000 {
> +                               label = "radio";
> +                               reg = <0xff0000 0x010000>;

Leading zero in "0x010000"

> +                               read-only;
> +                       };
> +
> +                       partition at 1000000 {
> +                               status = "disabled";
> +
> +                               label = "full";
> +                               reg = <0x0 0x1000000>;
> +                               read-only;
> +                       };

If I'm not mistaken, with this partition "disabled" users will need to build their own
image anyway to enable it. Might as well just drop this "full" partition then. It can
always be reconstructed from the other partitions if needed.


Best,
Sander