[PATCH 1/2] check-toolchain-clean.sh: fix shellcheck warnings

Petr Štetiar ynezz at true.cz
Fri Feb 25 02:45:43 PST 2022


Fixes following complaints and suggestions:

 In scripts/check-toolchain-clean.sh line 2:
 eval `grep CONFIG_GCC_VERSION .config`
      ^-- SC2046 (warning): Quote this to prevent word splitting.
      ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Signed-off-by: Petr Štetiar <ynezz at true.cz>
---
 scripts/check-toolchain-clean.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/check-toolchain-clean.sh b/scripts/check-toolchain-clean.sh
index af24e740b7d4..34b82dec5d22 100755
--- a/scripts/check-toolchain-clean.sh
+++ b/scripts/check-toolchain-clean.sh
@@ -1,5 +1,5 @@
 #!/bin/sh
-eval `grep CONFIG_GCC_VERSION .config`
+eval "$(grep CONFIG_GCC_VERSION .config)"
 CONFIG_TOOLCHAIN_BUILD_VER="$CONFIG_GCC_VERSION-$(cat toolchain/build_version)"
 touch .toolchain_build_ver
 [ "$CONFIG_TOOLCHAIN_BUILD_VER" = "$(cat .toolchain_build_ver)" ] && exit 0



More information about the openwrt-devel mailing list