[PATCH 1/3] realtek: clean up RTL930x timer DT node

Sander Vanheule sander at svanheule.net
Sun Feb 20 08:17:16 PST 2022


The Realtek timer node for RTL930x doesn't have any child nodes, making
the use of '#address-cells' quite pointless. It is also not an interrupt
controller, meaning it makes no sense to define '#interrupt-cells'.

The I/O address for this node is also wrong, but this is hidden by the
fact that the driver associated with this node bypasses the usual DT
machinery and does it's own thing. Correct the address to have a sane
value, even though it isn't actually used.

Fixes: a75b9e3ecb61 ("realtek: Adding RTL930X sub-target")
Signed-off-by: Sander Vanheule <sander at svanheule.net>
---
 target/linux/realtek/dts-5.10/rtl930x.dtsi | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/target/linux/realtek/dts-5.10/rtl930x.dtsi b/target/linux/realtek/dts-5.10/rtl930x.dtsi
index 31c021134261..0ac613454f58 100644
--- a/target/linux/realtek/dts-5.10/rtl930x.dtsi
+++ b/target/linux/realtek/dts-5.10/rtl930x.dtsi
@@ -59,9 +59,7 @@
 
 		rtl9300clock: rtl9300clock at 3200 {
 			compatible = "realtek,rtl9300clock";
-			reg = <0xb8003200 0x10>;
-			#address-cells = <0>;
-			#interrupt-cells = <1>;
+			reg = <0x3200 0x10>;
 
 			interrupt-parent = <&intc>;
 			interrupts = <7 5>, <8 5>;
-- 
2.35.1




More information about the openwrt-devel mailing list