[PATCH 0/6] backport fixes and improvements for MT7530

[Kristian Evensen]

Hi,

On Sun, Feb 6, 2022 at 9:52 AM Arınç ÜNAL <arinc.unal at arinc9.com> wrote:
>
> On 06/02/2022 00:15, Arınç ÜNAL wrote:
> > On 05/02/2022 21:23, Hauke Mehrtens wrote:
> >> On 2/5/22 19:21, Rosen Penev wrote:
> >>> On Sat, Feb 5, 2022 at 10:12 AM Hauke Mehrtens <hauke at hauke-m.de> wrote:
> >>>>
> >>>> On 2/3/22 13:06, DENG Qingfang wrote:
> >>>>> Hi,
> >>>>>
> >>>>> This series backports some patches from upstream to address the
> >>>>> current
> >>>>> MT7530 DSA driver's problems.
> >>>>>
> >>>>> Thanks.
> >>>>>
> >>>>> DENG Qingfang (6):
> >>>>>     kernel: backport MediaTek jumbo frame support
> >>>>>     kernel: backport MT7530 ageing time support
> >>>>>     kernel: backport MT7530 VLAN fix
> >>>>>     kernel: backport MT7530 MDB operations
> >>>>>     kernel: backport MediaTek Ethernet PHY driver
> >>>>>     kernel: backport MT7530 IRQ support
> >>>>>
> >>>> Hi,
> >>>>
> >>>> The last two patches are breaking the Linksys e8450 (mt7622) for me.
> >>>>
> >>>> I am getting these errors:
> >>> Note the commentary in
> >>> https://github.com/openwrt/openwrt/commit/3f4301e123f29348b4ad87578d62b7d1f5f210c6
> >>>
> >>>
> >>> The message in dmesg is harmless. It just says the functionality in
> >>> this patch needs dts bindings, which were only provided for ramips.
> >>
> >> The following error messages are a bigger problem:
> >
> > There was nothing wrong with that commit to revert it. But you could've
> > reverted the series as a whole since, technically, this patch series
> > broke the process so I guess it's better than nothing.
> >
> > I wonder if the PHY driver even works at its current state on upstream
> > for mt7531 or, more specifically, the built-in mt7531 on the MT7622X chips.
>
> Correction:
> MT7622X chips do not have a built-in mt7531 switch, there's a Fast
> Ethernet switch which is different.

When I applied the patches, I experienced the same issue as Hauke on a
custom mt7622 board (but with same switch setup). My "fix" was to add
the following to the mt7622 kernel-config to disable the PHY driver (I
have never experienced any of the issues reported on mt7621 without
the PHY driver):

# CONFIG_MEDIATEK_GE_PHY is not set

Otherwise, the patches included in this series turned out to be the
missing pieces of my performance analysis puzzle. My ISP gives a
non-standard (< 1500) MTU, so without the possibility to change MTU I
experienced fragmentation, etc.

Kristian