[PATCH 0/6] backport fixes and improvements for MT7530

[Hauke Mehrtens]

On 2/5/22 22:15, Arınç ÜNAL wrote:
> On 05/02/2022 21:23, Hauke Mehrtens wrote:
>> On 2/5/22 19:21, Rosen Penev wrote:
>>> On Sat, Feb 5, 2022 at 10:12 AM Hauke Mehrtens <hauke at hauke-m.de> wrote:
>>>>
>>>> On 2/3/22 13:06, DENG Qingfang wrote:
>>>>> Hi,
>>>>>
>>>>> This series backports some patches from upstream to address the 
>>>>> current
>>>>> MT7530 DSA driver's problems.
>>>>>
>>>>> Thanks.
>>>>>
>>>>> DENG Qingfang (6):
>>>>>     kernel: backport MediaTek jumbo frame support
>>>>>     kernel: backport MT7530 ageing time support
>>>>>     kernel: backport MT7530 VLAN fix
>>>>>     kernel: backport MT7530 MDB operations
>>>>>     kernel: backport MediaTek Ethernet PHY driver
>>>>>     kernel: backport MT7530 IRQ support
>>>>>
>>>> Hi,
>>>>
>>>> The last two patches are breaking the Linksys e8450 (mt7622) for me.
>>>>
>>>> I am getting these errors:
>>> Note the commentary in
>>> https://github.com/openwrt/openwrt/commit/3f4301e123f29348b4ad87578d62b7d1f5f210c6 
>>>
>>>
>>> The message in dmesg is harmless. It just says the functionality in
>>> this patch needs dts bindings, which were only provided for ramips.
>>
>> The following error messages are a bigger problem:
> 
> There was nothing wrong with that commit to revert it. But you could've 
> reverted the series as a whole since, technically, this patch series 
> broke the process so I guess it's better than nothing.

Ethernet was not working at all on my device. I did not want to debug 
this, but revert the braking changes in master.

> I wonder if the PHY driver even works at its current state on upstream 
> for mt7531 or, more specifically, the built-in mt7531 on the MT7622X chips.

The PHY driver expects that the correct PHY mode is configured, but we 
do not specify any phy-mode in the dts for this device and probably also 
others.

Hauke