[PATCH] interface-ip: stop setting prefix indicator flag when IPv6 prefix lifetime changes

Alan Swanson reiver at improbability.net
Tue Aug 23 07:33:28 PDT 2022


Since hnetd has now been dead for years we can safely revert commit
a03216660797173fbe67866f75564e3fec9c1e8d which was causing unnecessarily
frequent interface triggers and service reloads for IPv6 prefix lifetime
changes.

Fixes: FS#713 https://github.com/openwrt/openwrt/issues/5723
Fixes: FS#1492 https://github.com/openwrt/openwrt/issues/6454

Signed-off-by: Alan Swanson <reiver at improbability.net>
---
 interface-ip.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/interface-ip.c b/interface-ip.c
index ab4a5cf..fd2b2ab 100644
--- a/interface-ip.c
+++ b/interface-ip.c
@@ -1302,10 +1302,6 @@ interface_update_prefix(struct vlist_tree *tree,
 		list_for_each_entry(c, &prefix_new->assignments, head)
 			if ((iface = vlist_find(&interfaces, c->name, iface, node)))
 				interface_set_prefix_address(c, prefix_new, iface, new_valid);
-
-		if (prefix_new->preferred_until != prefix_old->preferred_until ||
-				prefix_new->valid_until != prefix_old->valid_until)
-			ip->iface->updated |= IUF_PREFIX;
 	} else if (node_new) {
 		/* Set null-route to avoid routing loops */
 		system_add_route(NULL, &route);
-- 
2.35.1




More information about the openwrt-devel mailing list