[PATCH] build: always set CONFIG_IPV6

[Enrico Mioso]

Hello all!!

In my opinion, it would be better to try keeping this option available.
Surely, !IPV6 is not a common scenario these days. But I think OpenWrt might be useful to catch bugs like the one fixed in commit 77fc73ac89be96ec8f39e8efa53885caa7cb3645
in the Linux kernel's git tree.

So, for what it's worth, a NACKfrom me.

Enrico


On Thu, 18 Aug 2022, Paul Spooren wrote:

> Date: Thu, 18 Aug 2022 17:33:42
> From: Paul Spooren <mail at aparcar.org>
> To: Stijn Tintel <stijn at linux-ipv6.be>
> Cc: Thibaut <hacks at slashdirt.org>,
>     openwrt-devel <openwrt-devel at lists.openwrt.org>
> Subject: Re: [PATCH] build: always set CONFIG_IPV6
> 
>
>
>> On 18. Aug 2022, at 16:07, Stijn Tintel <stijn at linux-ipv6.be> wrote:
>> 
>> On 18/08/2022 17:03, Thibaut wrote:
>>>> Le 18 août 2022 à 15:40, Stijn Tintel <stijn at linux-ipv6.be> a écrit :
>>>> 
>>>> On 16/08/2022 20:00, Thibaut VARÈNE wrote:
>>>>> Disabling this build tunable breaks build and seems unrealistically
>>>>> likely to be fixed.
>>>>> 
>>>>> This patch sets the related CONFIG to always true and removes the
>>>>> config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever
>>>>> be fixed, easy to revert.
>>>> If we're always going to set it to yes, just drop the option entirely and enable it in the generic kernel configs. Aside from that:
>>> CONFIG_IPV6 is not a kernel config, it’s a tree-wide one.
>>> 
>>> My idea was to keep the change as small as possible should we ever want to revert, while preventing further pointless bugreports[1].
>>> 
>>> Entirely removing the config option requires more invasive changes throughout the tree and the package repositories, which is significantly less trivial than this "first step".
>>> 
>>> Cheers,
>>> Thibaut
>>> 
>>> [1] https://github.com/openwrt/openwrt/issues/9580
>> 
>> OK, in that case, let's await at least one more ACK and we can start
>> with this.
>
> Per request:
>
> Acked-by: Paul Spooren <mail at aparcar.org>
>
>> 
>> Thanks,
>> Stijn
>> 
>> 
>> _______________________________________________
>> openwrt-devel mailing list
>> openwrt-devel at lists.openwrt.org
>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel