[PATCH] sunxi: bring up DSA b53 switch on Lamobo R1

Adrian Schmutzler mail at adrianschmutzler.de
Sat Sep 11 10:19:37 PDT 2021


Hi,

> --- a/target/linux/sunxi/image/cortexa7.mk
> +++ b/target/linux/sunxi/image/cortexa7.mk
> @@ -64,7 +64,10 @@ TARGET_DEVICES += friendlyarm_zeropi  define
> Device/lamobo_lamobo-r1
>    DEVICE_VENDOR := Lamobo
>    DEVICE_MODEL := Lamobo R1
> -  DEVICE_PACKAGES:=kmod-ata-sunxi kmod-rtl8192cu swconfig wpad-basic-
> wolfssl
> +  DEVICE_ALT0_VENDOR := Bananapi
> +  DEVICE_ALT0_MODEL := BPi-R1
> +  DEVICE_PACKAGES := kmod-ata-sunxi kmod-rtl8192cu wpad-basic-wolfssl
> + DEVICE_COMPAT_VERSION := 2.0

compat_version needs to be set in two places. First for the image, which you
did here, and second for the config, which you seem to miss (board.d or
uci-default, depending on what kind of change you do).

Apart from that, note that changing the major version means that upgrade is
not possible at all (even without saving config), and factory flashing is
required. I would rather have expected version 1.1 here, since your change
should be covered by an update without keeping config (sysupgrade -n)?

Apart from that, adding a proper message would help.

You should get an overview of all the necessary changes here:
https://github.com/openwrt/openwrt/commit/494f12c52df6767ec0fabf2b2fac8f4533
23a4c5

For a single device, you would probably not need the separate
Device/dsa-migration definition, though, but could just add the two
variables to the device.

Best

Adrian





>    SOC := sun7i-a20
>  endef
>  TARGET_DEVICES += lamobo_lamobo-r1
> --
> 2.33.0
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel




More information about the openwrt-devel mailing list