[PATCH] base-files: make os-release symbolic link absolute

Jo-Philipp Wich jo at mein.io
Wed Sep 8 14:07:12 PDT 2021


Hi,

> Did you check that none of the build scripts try to access this file? In
> case they do, they'd fail since an absolute path wouldn't exists on the
> building host system.

apart from that it might break 3rd party workflows for no obvious
reason. The existing absolute symlinks mentioned all point to ephemeral
resources while os-release points to an actual fixed file.

In doubt, I'd personally favor keeping things as-is as this change is
not actually fixing or improving things, just breaking potential
use-cases (e.g. `cat /some/mounted_rootfs/etc/os-release`)

~ Jo



More information about the openwrt-devel mailing list