[PATCH] realtek: add missing GPIO irq properties

Sander Vanheule sander at svanheule.net
Wed Nov 24 21:40:07 PST 2021


The internal GPIO controller on RTL838x is also an IRQ controller, which
requires the 'interrupt-controller' and '#interrupts-cells' properties
to be present in the device tree.

Reported-by: INAGAKI Hiroshi <musashino.open at gmail.com>
Signed-off-by: Sander Vanheule <sander at svanheule.net>
---
 target/linux/realtek/dts-5.10/rtl838x.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/target/linux/realtek/dts-5.10/rtl838x.dtsi b/target/linux/realtek/dts-5.10/rtl838x.dtsi
index f356f8fcde09..899c1731fb51 100644
--- a/target/linux/realtek/dts-5.10/rtl838x.dtsi
+++ b/target/linux/realtek/dts-5.10/rtl838x.dtsi
@@ -170,9 +170,13 @@
 		gpio0: gpio-controller at 3500 {
 			compatible = "realtek,rtl8380-gpio", "realtek,otto-gpio";
 			reg = <0x3500 0x20>;
+
 			gpio-controller;
 			#gpio-cells = <2>;
 			ngpios = <24>;
+
+			interrupt-controller;
+			#interrupt-cells = <2>;
 			interrupt-parent = <&intc>;
 			interrupts = <23>;
 		};
-- 
2.33.1




More information about the openwrt-devel mailing list