[PATCH 2/2] ath79: mikrotik: Change the moment of routerboot partition parser init

Thibaut hacks at slashdirt.org
Thu Nov 11 08:41:17 PST 2021



> Le 11 nov. 2021 à 16:45, Denis K <denis281089 at gmail.com> a écrit :
> 
> I see two ways to eliminate this race condition:
> 1) late_initcall of routerboot module, only a single line need to be changed,

OK, let’s do that as a workaround and hope that deferred probes won’t overlap past late_initcall()

> 2) Somehow add a probe function to routerboot module. May be it should be
> called from routerboot_partitions_parse function (from
> mtd/parsers/routerbootpart.c).

No. There’s no reason why one should depend on the other (hard/soft config could be defined statically without using the parser, and the driver should still work then).

HTH
T


More information about the openwrt-devel mailing list